752400 - Give summary and URL of bugs added or removed from dependencies in bugmail

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

bug 97956 is about "Give summary and URL of bugs added or removed from dependencies in bugmail" upstream.

given the uncertainty about how this should be resolved, and the added benefit this would provide to bugmail, we should make a bmo specific hack to show bug summaries for bugs mentioned in dependency changes at the end of bugmail, and get it deployed quickly.

then we can tackle upstream and argue the best way to solve it there.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[:glob ✱]

Attachment: sample message

Comment 3

[Frédéric Buclin]

Comment on attachment 621503 [details] [diff] [review]
patch v1

Looks like there is no security check done. Unprivileged users will see the bug summary of bugs restricted to groups they cannot access. You have to call $user->visible_bugs first.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 621503 [details] [diff] [review]
patch v1

Review of attachment 621503 [details] [diff] [review]:
-----------------------------------------------------------------

As LpSolit mentioned, we need to filter the referenced bug data based on the users permissions to see the bug. Something like this would be sufficient:

@@ -430,6 +439,8 @@
                 }
             }
 
+            @referenced_bugs = @{$user->visible_bugs(\@referenced_bugs)};
+
             # Make sure the user isn't in the nomail list, and the insider and 
             # dep checks passed.
             # Upstreaming: when we port to 4.2, check the login names of the

dkl

Comment 5

[:glob ✱]

Attachment: patch v2

thanks for catching that LpSolit!

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 621608 [details] [diff] [review]
patch v2

Review of attachment 621608 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm. Need to either scrub the subject or omit the entry altogether if the referenced bug is private to one or more "secure" groups requiring an encryption key.

Comment 7

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #6)
> Hmm. Need to either scrub the subject or omit the entry altogether if the
> referenced bug is private to one or more "secure" groups requiring an
> encryption key.

May need a new hook that filters the referenced bug list since SecureMail is an extension.

dkl

Comment 8

[:glob ✱]

Attachment: patch v3

Comment 9

[David Lawrence [:dkl]]

Comment on attachment 621900 [details] [diff] [review]
patch v3

Review of attachment 621900 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good by inspection. r=dkl

::: template/en/default/email/newchangedmail.txt.tmpl
@@ +64,5 @@
> +
> +Referenced [% terms.Bugs %]:
> +
> +[% FOREACH ref = referenced_bugs %]
> +[%+ urlbase %]show_bug.cgi?id=[% ref.id %]

Nit: fix on checkin

[%+ urlbase FILTER none %]show_bug.cgi?id=[% ref.id FILTER url_quote %]

(Note: "FILTER uri" for 4.2)

Comment 10

[:glob ✱]

thanks dkl :)

> (Note: "FILTER uri" for 4.2)
this patch won't apply without reasonable work to 4.2, i've moved that to bug 753319.

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified Bugzilla/BugMail.pm
modified extensions/SecureMail/Extension.pm
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 8172.

Committing to: bzr+ssh://[e-mail]/bugzilla/extensions/securemail/4.0/
modified Extension.pm
Committed revision 20.

Comment 11

[Ben Bucksch (:BenB)]

:glob, thanks! This will make bugzilla so much more usable!
I'd kiss you, but that would be interpreted the wrong way.

Comment 12

[Martijn Wargers (dead)]

Wow! Thank you! This works wonderful.

Comment 13

[Andre Klapper]

Is there some work going on to upstream this bmo-only feature, to fix bug 97956?